Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Support Arguments on root module #308

Open
jkroepke opened this issue Nov 7, 2023 · 3 comments
Open

config: Support Arguments on root module #308

jkroepke opened this issue Nov 7, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@jkroepke
Copy link
Contributor

jkroepke commented Nov 7, 2023

Request

Grafana Agent have arguments block which only exists on module.

I had the idea to support arguments on the root context, too. arguments can be defined via CLI argument, e.g. --set arguments=value.

Use case

It would be an alternative in addition to environment variables parameterize static configuration.

@jkroepke jkroepke added the enhancement New feature or request label Nov 7, 2023
@tpaschalis
Copy link
Member

That is an interesting idea to explore, and an alternative to the debug.variables component idea we'd discussed in the past, with a tradeoff between dynamic behavior and more understandable configuration.

I'm not 100% sold on it yet, but it can be discussed as part of grafana/agent#5547.

@jkroepke
Copy link
Contributor Author

Origin: https://docs.docker.com/engine/reference/commandline/buildx_bake/#set

I found that pattern on the docker buildx plugin. At the moment, I have to use environment variables which is also fine.

Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants