fix(pyroscope): allow slashes in application name #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcsanmi
force-pushed
the
marcsanmi/allow-service-name-slashes
branch
from
9657657
to
92c85ab
Compare
marcsanmi
force-pushed
the
marcsanmi/allow-service-name-slashes
branch
from
92c85ab
to
a2d40b9
Compare
marcsanmi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The change extends tag name validation to allow slashes, enabling hierarchical service naming patterns.
Which issue(s) this PR fixes
Closes #2158
Relates to https://github.com/grafana/pyroscope-squad/issues/257
Notes to the Reviewer
PR Checklist