Reconciles k8s versions at vX.28.7 and fixes test skip drift #6670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed some stale warnings about testcontainers, which have drifted. This made me notice many versions of k8s dependencies (go or image versions) weren't coherent. I reconciled everything and changed comments on the remaining broken parts, which aren't broken due to testcontainers. Signed-off-by: Adrian Cole <[email protected]>
|
|
|
ps I took a peek at the GHA workflows and not sure which is actually running the tests marked !nodocker, as I only see a go test for nodocker. |
| // TODO: this is broken with go 1.20.6 | ||
| // waiting on https://github.com/testcontainers/testcontainers-go/issues/1359 | ||
| t.Skip() | ||
| t.Skip("TODO: unable to retrieve the complete list of server APIs: monitoring.grafana.com/v1alpha1") |
There was a problem hiding this comment.
this looked like a legit failure, so I left it for someone who might now be able to resolve it!
rfratto
added
variant/static
4 tasks
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I noticed some stale warnings about testcontainers, which have drifted. This made me notice many versions of k8s dependencies (go or image versions) weren't coherent. I reconciled everything and changed comments on the remaining broken parts, which aren't broken due to testcontainers.
Which issue(s) this PR fixes
I didn't raise a bookkeeping issue first, rather just fixed it. If you want the former, I can do one.
Notes to the Reviewer
PR Checklist