Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelcol.connector.spanmetrics should support the metrics_expiration option #6860

Open
madaraszg-tulip opened this issue Apr 15, 2024 · 1 comment
Labels
enhancement New feature or request needs-attention An issue or PR has been sitting around and needs attention.

Comments

@madaraszg-tulip
Copy link

Request

Currently the spanmetrics connector never stops feeding stale metrics.

The upstream code has recently implemented the metrics_expiration option, it would be great if grafana-agent could make use of it.

open-telemetry/opentelemetry-collector-contrib#31106

Use case

We would like to keep our cardinality lower by not feeding metrics which we consider stale.

@madaraszg-tulip madaraszg-tulip added the enhancement New feature or request label Apr 15, 2024
Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-attention An issue or PR has been sitting around and needs attention.
Projects
None yet
Development

No branches or pull requests

1 participant