fix: close procRoot dir

testwill · web-flow · commit 7bf2b854ef24 · 2024-05-15T17:00:29.000+08:00
diff --git a/internal/component/pyroscope/java/asprof/asprof.go b/internal/component/pyroscope/java/asprof/asprof.go
@@ -115,6 +115,7 @@ func (p *Profiler) CopyLib(dist *Distribution, pid int) error {
 	if err != nil {
 		return fmt.Errorf("failed to open proc root %s: %w", procRoot, err)
 	}
+	defer procRootFile.Close()
 	dstLibPath := strings.TrimPrefix(dist.LibPath(), "/")
 	dstLauncherPath := strings.TrimPrefix(dist.LauncherPath(), "/")
 	if err = writeFile(procRootFile, dstLibPath, libData, false); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -115,6 +115,7 @@ func (p Profiler) CopyLib(dist Distribution, pid int) error {`
`115`	`115`	`if err != nil {`
`116`	`116`	`return fmt.Errorf("failed to open proc root %s: %w", procRoot, err)`
`117`	`117`	`}`
	`118`	`+ defer procRootFile.Close()`
`118`	`119`	`dstLibPath := strings.TrimPrefix(dist.LibPath(), "/")`
`119`	`120`	`dstLauncherPath := strings.TrimPrefix(dist.LauncherPath(), "/")`
`120`	`121`	`if err = writeFile(procRootFile, dstLibPath, libData, false); err != nil {`