Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphviz dot produces indeterminsitic result, breaking the CI SVG check #339

Open
knaeckeKami opened this issue Aug 6, 2022 · 0 comments

Comments

@knaeckeKami
Copy link
Collaborator

repeat 20 multipack info | dot -Tsvg -x | md5

outputs

2db5aa6b11b6b4f52e8283f2435d5212
d6156c52000e690a7c3e72e52553b9db
2db5aa6b11b6b4f52e8283f2435d5212
2db5aa6b11b6b4f52e8283f2435d5212
1979929664b2fbc1bce4975000f37ac3
5201338dd5c626e72645bbcedf9ea4bf
5201338dd5c626e72645bbcedf9ea4bf
2db5aa6b11b6b4f52e8283f2435d5212
5201338dd5c626e72645bbcedf9ea4bf
2db5aa6b11b6b4f52e8283f2435d5212
2db5aa6b11b6b4f52e8283f2435d5212
2db5aa6b11b6b4f52e8283f2435d5212
5201338dd5c626e72645bbcedf9ea4bf
5201338dd5c626e72645bbcedf9ea4bf
5201338dd5c626e72645bbcedf9ea4bf
5201338dd5c626e72645bbcedf9ea4bf
5201338dd5c626e72645bbcedf9ea4bf
2db5aa6b11b6b4f52e8283f2435d5212
5201338dd5c626e72645bbcedf9ea4bf
1979929664b2fbc1bce4975000f37ac3

on my machine.
It should output the same hash every time if the algorithm was deterministic.
The output of multipack info is deterministic, so it must be dot which is the culprit here.
The actual difference in the SVG is tiny, it seems to come down to some rounding differences.

I believe this is a known issue of dot discussed here: https://gitlab.com/graphviz/graphviz/-/issues/1767

Because of this, the check SVG step in the CI does not really make sense in my opinion,
since it would often fail even though the SVG image is up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant