Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #2

Open
dselivanov opened this issue Jun 8, 2018 · 10 comments
Open

Development #2

dselivanov opened this issue Jun 8, 2018 · 10 comments
Assignees

Comments

@dselivanov
Copy link

@cdeterman I can try to give a shot on this. I just may need help with initial set-up of the repository - how to link to vienacl, what is the preferred structure of S4 classes, etc.

@dselivanov dselivanov changed the title Kick-start development Development Jun 8, 2018
@cdeterman
Copy link
Member

@dselivanov thanks for the offer. I can put together a general skeleton that we can start to work from.

cdeterman added a commit that referenced this issue Jun 14, 2018
…thod export for the 'typeof' method doesn't work in the devtools::test() call because of the new enviornment it generates internally. I suspect I am overlooking something silly for the S4 methods.
@cdeterman
Copy link
Member

@dselivanov A very minimal start at the moment. I wanted to push it up as I have encountered a silly error when using devtools::test() where my S4 typeof method is failing. I am also tracking down a ViennaCL related issue with the shared_ptr useage. It is at least a start.

@dselivanov
Copy link
Author

Thanks you @cdeterman ! Now I believe at least we can work asynchronously. Not sure when I actually will be able to start with this, but it is something which I want to give a shot.

@cdeterman cdeterman self-assigned this Jun 21, 2018
@cdeterman
Copy link
Member

@dselivanov I am actually stuck at the moment dealing with that S4 issue. I have posted an SO question that hopefully some kind soul can lend some insight. It is a curious issue with S4 methods in multiple packages.

@dselivanov
Copy link
Author

dselivanov commented Jun 21, 2018 via email

@cdeterman
Copy link
Member

@dselivanov the problem was coming because typeof is not a generic function. I am now creating a separate generics package that creates general purpose generics to resolve this issue across packages. Once everything is stable there, I will submit that to CRAN as well. I have confirmed that this solves the problem locally.

Regarding your previous point, I don't want to bloat the gpuR package. It is already a pretty large package and sparse operations may be more of a specialty thing. I would like to maintain that separately.

@jeffkeller87
Copy link

@cdeterman just wondering if this is still being pursued. The gpuR package is just amazing and I'd love to be able to use it for sparse matrices as well.

@cdeterman
Copy link
Member

@jeffkeller87 I certainly want to, I simply don't have the bandwidth currently. I would love to have a collaborator to get this moving along further. But currently it is stalled.

@jeffkeller87
Copy link

Thanks for the quick reply @cdeterman. I am interested in collaborating--what's the best way to get in touch? Is that here in GitHub Issues? Signal? Riot/Matrix? I'd like to better understand the current state of gpuRsparse and what tasks you see to get it to a state worthy of a CRAN submission.

@cdeterman
Copy link
Member

@jeffkeller87 sorry for delayed response, I have been quite busy lately.

I have set up a gitter.im room here where we can have general discussions. Naturally, issues should be created for anything concrete.

The general state of gpuRsparse is essentially non-functional. I simply have the outline for it formed but there should be much to be leveraged directly from ViennaCL. The main issue I initially ran in to was dealing with the S4 generic problem. I have seen that there is a generics package with CRAN so I will need to change my proposed package name before I can submit that.

Afterwards, it will essentially be working on implementing all the basic operations (e.g. addition, subtraction, etc.) in addition to working on the sparse solvers that are part of ViennaCL.

I am still struggling to get gpuR accepted once again currently. For some reason the build is failing on CRAN that I cannot replicate. Hopefully it is resolved soon and I can find some more time to dedicate to these packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants