Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI test build as github workflow action #517

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ndim
Copy link
Member

@ndim ndim commented Jun 22, 2022

No description provided.

@ndim
Copy link
Member Author

ndim commented Jun 22, 2022

So make check fails when built with libexif support:

https://github.com/gphoto/gphoto2/runs/6997551110?check_suite_focus=true#step:3:119

libexif-dev is already the newest version (0.6.21-6ubuntu0.4).
libexif-dev set to manually installed.

https://github.com/gphoto/gphoto2/runs/6997551110?check_suite_focus=true#step:7:331

*** Running "EXIF display" test
++ ../gphoto2/gphoto2 '--camera=Directory Browse' --port=disk:./staging --show-exif=4
+ EXITCODE=0
+ set +x
Test test037 FAILED: unexpected output
--- ./data/test037.result	2022-06-22 04:47:43.535352876 +0000
+++ /home/runner/work/gphoto2/gphoto2/tests/log/test037.out	2022-06-22 04:48:30.337787441 +0000
@@ -16,7 +16,7 @@
 ComponentsConfigurat|Y Cb Cr -                                                  
 UserComment         |Public domain EXIF test image                              
 FlashPixVersion     |FlashPix Version 1.0                                       
-ColorSpace          |Uncalibrated                                               
+ColorSpace          |Internal error (unknown value 65535)                       
 PixelXDimension     |32                                                         
 PixelYDimension     |32                                                         
 --------------------+-----------------------------------------------------------

@ndim
Copy link
Member Author

ndim commented Jun 22, 2022

As make check works for me locally, I have checked my local libexif version: 0.6.24-2.fc36.x86_64 versus the CI system Ubuntu OS's 0.6.21-6ubuntu0.4 where the difference occurs and make check fails:

-ColorSpace          |Uncalibrated                                               
+ColorSpace          |Internal error (unknown value 65535)                       

How serious is this? Should gphoto2's make check actually fail here?

ndim added 2 commits July 4, 2022 11:10
This stops running all the check related targets ("check",
"installcheck", "distcheck") as those are failing.

Testing "make all" and "make install" work is still better
than nothing. We can easily re-enable the checks once we
have made them run again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant