Skip to content

Commit

Permalink
handle negative mtime on 32bit
Browse files Browse the repository at this point in the history 
fixes gphoto/libgphoto2#934
  • Loading branch information
@msmeissn
msmeissn committed Nov 9, 2023
1 parent 0fad139 commit 672d2a8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/data/test001.param
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
TITLE='Recursive directory file list'
COMMAND='$PROGRAM --camera="Directory Browse" --port=disk:"$STAGINGDIR" -L 2> "$ERRFILE" > "$OUTFILE"'
SEDCOMMAND='s@\(in folder .\).*/@\1@; s/^\(#.*\)\( [1-9][0-9]\{1,12\}\)$/\1 <<MTIME>>/'
SEDCOMMAND='s@\(in folder .\).*/@\1@; s/^\(#.*\)\( [-1-9][0-9]\{1,12\}\)$/\1 <<MTIME>>/'

2 comments on commit 672d2a8

@ncopa
Copy link

@ncopa ncopa commented on 672d2a8 Nov 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any valid negative mtimes? I think this only hides the real problem that 32 bit long is used with 64 bit time_t.

never mind. I see that the proper fix is found in f3c01c7

@msmeissn
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i removed this hack again, lets hope itworks

Please sign in to comment.