Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow upgrades to Drupal 11 compatible modules #335

Open
acbramley opened this issue Aug 22, 2024 · 4 comments · May be fixed by #336
Open

Allow upgrades to Drupal 11 compatible modules #335

acbramley opened this issue Aug 22, 2024 · 4 comments · May be fixed by #336
Assignees
Labels
CAB pending Appending decision from the GovCMS CAB

Comments

@acbramley
Copy link
Contributor

Some of the modules in the require section are locked to versions that do not support Drupal 11. This means PaaS sites are unable to update to Drupal 11 while using this tooling.

@acbramley acbramley linked a pull request Aug 22, 2024 that will close this issue
@steveworley
Copy link
Contributor

Thanks @acbramley — I'll raise this tomorrow internally at the steering committee and we'll look to get this resolved one way or another shortly after their decision.

@steveworley steveworley self-assigned this Sep 4, 2024
@steveworley steveworley added the CAB pending Appending decision from the GovCMS CAB label Sep 4, 2024
@acbramley
Copy link
Contributor Author

These hardcoded versions seem to be a recent thing, I just bumped scaffold-tooling and it downgraded some of my modules. This should be resolved ASAP f2f726e...63812fc

@stooit
Copy link
Collaborator

stooit commented Sep 5, 2024

@acbramley scaffold-tooling and other components follow the major release version of the GovCMS distribution. At the moment there is no official support for D11 so we need to be guided by the GovCMS team on timelines for providing this support to PaaS customers, we will have an answer for you on this soon.

With regards to pinning, GovCMS have mandated that both the distribution and tooling (e.g this repo as well as the govcms/lagoon repo) are all using pinned versions to ensure we are building and testing against known versions of every component.

I do not think we will move back to looser constraints here, but we will look to add a new 11.x-develop branch that adds support for D11 (again based on GovCMS' timelines/priorities).

For now PaaS sites can drop the inclusion of scaffold-tooling and BYO composer versions for D11 support, or fork this repo and start an 11.x-develop branch that can be submitted as a PR for us to review

@acbramley
Copy link
Contributor Author

Hi @stooit dropping scaffold-tooling doesn't seem to be an option. It provides many scripts used by the govcms deployment process. I'm not really keen to reimplement all of that. It doesn't seem wise to require PaaS products to pin to specific versions...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CAB pending Appending decision from the GovCMS CAB
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants