Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Multiplayer Support #81

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

huiyun862
Copy link

Pig Game Multi Scrn

This pull request does the following:

  • You can input the number of players for the game; press new game to set players.
  • There is no limit to the number of players; the players will appear on the left panel in individual cards.
  • Various buttons are repositioned to more appropriate locations.
  • Only one panel is used; this panel will change depending on which player.

It's been a week, so there are many changes to the original repo. Maybe leave this as a new branch?

@NicholasACTran
Copy link
Collaborator

I like this implementation. Can you include support for the setting score goal and rolling two dice, both that have been included in the current version?

@huiyun862
Copy link
Author

Definitely, but this implementation took longer than expected, and it may take until next Saturday before I have time to work on it again. Since I am trying to complete my 4 pull requests for Hacktoberfest, is it okay if I open a separate pull request that implements the requested features?

@NicholasACTran
Copy link
Collaborator

@huiyun862 You can, but we cannot merge this in until those changes are made, since it would erase several features that have been worked on and merged in already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants