added customized player names #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouri-panda
requested changes
Oct 10, 2020
app.js
Outdated
Comment on lines
83
to
84
| var r = confirm("Would you like to change the name of players?"); | ||
| if (r == true) { |
There was a problem hiding this comment.
This is not how variables should declare.
app.js
Outdated
| @@ -80,6 +80,13 @@ function newGame() { | |||
| score1.textContent = '0'; | |||
| current0.textContent = '0'; | |||
| current1.textContent = '0'; | |||
| var r = confirm("Would you like to change the name of players?"); | |||
| if (r == true) { | |||
| var person = prompt("Please enter your name", player0); | |||
app.js
Outdated
| var r = confirm("Would you like to change the name of players?"); | ||
| if (r == true) { | ||
| var person = prompt("Please enter your name", player0); | ||
| document.getElementById("name-0").innerHTML =person; |
app.js
Outdated
| if (r == true) { | ||
| var person = prompt("Please enter your name", player0); | ||
| document.getElementById("name-0").innerHTML =person; | ||
| var person2 = prompt("Please enter your name", player1); |
app.js
Outdated
| var person = prompt("Please enter your name", player0); | ||
| document.getElementById("name-0").innerHTML =person; | ||
| var person2 = prompt("Please enter your name", player1); | ||
| document.getElementById("name-1").innerHTML =person2; |
index.html
Outdated
Comment on lines
80
to
82
| if (player0 != null) { | ||
| document.getElementById("name-0").innerHTML =player0; | ||
| } |
There was a problem hiding this comment.
This is not properly indented.
index.html
Outdated
Comment on lines
84
to
85
| if (player1 != null) { | ||
| document.getElementById("name-1").innerHTML =player1; |
There was a problem hiding this comment.
This is not properly indented too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the functionality by which the players can change their names before starting the game and also after starting a new game.