Integrate callback and sla #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 8, 2025 08:22
added 9 commits
September 23, 2025 11:41
…_callback_and_sla
added 2 commits
September 24, 2025 15:29
| return me.ToErr() | ||
| } | ||
|
|
||
| func (s *JobRunService) createOperatorRun(ctx context.Context, event *scheduler.Event, operatorType scheduler.OperatorType) error { |
There was a problem hiding this comment.
we could have kept create operator run & register sla's independent we don't need to keep them in a same function.
There was a problem hiding this comment.
yes we can do this, logically right
| return err | ||
| } | ||
|
|
||
| if existingOperatorRunState == nil || *existingOperatorRunState != scheduler.StateRetry { |
There was a problem hiding this comment.
In my opinion we should see this whole operation as two sub functions fetchAllSLAAlertConfigs & Registration.
Mryashbhardwaj
commented
Sep 25, 2025
| return err | ||
| } | ||
|
|
||
| switch event.Type { |
There was a problem hiding this comment.
same things can be done here as well
* fix: enrich event context in airflow callbacks --------- Co-authored-by: Yash Bhardwaj <[email protected]>
sravankorumilli
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.