Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic from missing root test #416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix panic from missing root test #416

wants to merge 1 commit into from

Conversation

dnephin
Copy link
Member

@dnephin dnephin commented Jun 17, 2024

Fixes #413

I should add a test case for this before merging.

@dnephin dnephin mentioned this pull request Jun 17, 2024
Open
dnephin
dnephin commented Jun 17, 2024
View reviewed changes
testjson/execution.go
rootTestCase := p.running[root]
rootTestCase, ok := p.running[root]
if !ok {
rootTestCase = p.newTestCaseFromEvent(event)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may need to adjust the name of the test here to remove the /subtest part.

@pohly
Copy link

pohly commented Jun 17, 2024

It might be worth checking more thoroughly what go test -bench -json produces, if time permits. As a hotfix this seems okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic when converting "go test -bench" output
2 participants
@dnephin @pohly