Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Unsafe ComponentWill... lifecycle methods #33

Open
dkemper01 opened this issue May 26, 2020 · 1 comment
Open

Unsafe ComponentWill... lifecycle methods #33

dkemper01 opened this issue May 26, 2020 · 1 comment

Comments

@dkemper01
Copy link

Code at issue:
https://github.com/gorangajic/react-svg-morph/blob/master/src/MorphReplace.js#L26, among others.

More on this:

Syntactically speaking, the methods as you have implemented them currently will no longer function as of React 17. You will at least need to use the UNSAFE variants, although I recommend not using them at all, or just using componentDidUpdate.

@dkemper01 dkemper01 changed the title Unsafe ComponentWill... lifecycle methos Unsafe ComponentWill... lifecycle methods May 26, 2020
@gorangajic
Copy link
Owner

Thank you for reporting this. Currently, I don't use this lib in any active project. So, if you want to create that fix I will be more than happy to review your pull request and release that change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants