Lint errors in analysis.js

[laptou]

@seunomonije the linter reports these errors in analysis.js; please fix them

/home/runner/work/step99-2020/step99-2020/client/js/analysis.js
##[error]   2:5   error    'formSubmit' is never reassigned. Use 'const' instead  prefer-const
##[error]   2:42  error    Strings must use singlequote                           quotes
##[error]   3:29  error    Strings must use singlequote                           quotes
##[warning]   5:1   warning  Missing JSDoc @returns declaration                     jsdoc/require-returns
##[error]   7:4   error    Trailing spaces not allowed                            no-trailing-spaces
##[error]  11:38  error    'elId' is not defined                                  no-undef
##[error]  11:44  error    Trailing spaces not allowed                            no-trailing-spaces

✖ 7 problems (6 errors, 1 warning)
  5 errors and 0 warnings potentially fixable with the `--fix` option.

[laptou]

Some of these are fixed in #29, but there are still lots of JSDoc lint errors on the Donut-charts branch:

   8:1   warning  Missing JSDoc @returns declaration                                jsdoc/require-returns
  19:0   warning  There must be a newline after the description of the JSDoc block  jsdoc/newline-after-description
  20:0   warning  Missing JSDoc @param "elId" description                           jsdoc/require-param-description
  20:0   error    Missing JSDoc @param "elId" type                                  jsdoc/require-param-type
  21:0   warning  Missing JSDoc @param "value" description                          jsdoc/require-param-description
  21:0   error    Missing JSDoc @param "value" type                                 jsdoc/require-param-type
  31:10  error    'addElement' is defined but never used                            no-unused-vars
  49:1   warning  Missing JSDoc @returns declaration                                jsdoc/require-returns
  80:1   warning  Missing JSDoc @returns declaration                                jsdoc/require-returns
  81:0   warning  There must be a newline after the description of the JSDoc block  jsdoc/newline-after-description
  82:0   warning  Missing JSDoc @param "el" description                             jsdoc/require-param-description
  82:0   error    Missing JSDoc @param "el" type                                    jsdoc/require-param-type

✖ 12 problems (4 errors, 8 warnings)
  0 errors and 2 warnings potentially fixable with the `--fix` option.

Also, what does 'will be overwritten in merge' mean?

[seunomonije]

The top part of analysis.js (up until addElement()) will not make it when I merge donut-charts into master. It's been completely changed and reformatteed in a prior pull request.

[laptou]

@seunomonije Since #29 ended up being closed without being merged, this is still an issue.