Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to modify downstream channel size #910

Open
ajohnstonTC opened this issue Mar 20, 2024 · 0 comments
Open

Add configuration to modify downstream channel size #910

ajohnstonTC opened this issue Mar 20, 2024 · 0 comments
Labels
kind/bug Something isn't working

Comments

@ajohnstonTC
Copy link

What happened:
Write packets from the server to clients are dropped due to the downstream channel being bounded with a hardcoded size:

let (tx, mut downstream_receiver) = mpsc::channel::<UpstreamChannelData>(5);

What you expected to happen:
Quilkin provides a configuration option to change the size of the downstream channel to mitigate dropped packets.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Quilkin version: v0.8.0
  • Execution environment (binary, container, etc): Container in Kubernetes
  • Operating system: Amazon Linux 2
  • Custom filters? (Yes/No - if so, what do they do?): No
  • Log(s):
{"timestamp":"2024-03-20T18:49:02.030015Z","level":"ERROR","fields":{"message":"downstream channel full"},"target":"quilkin::cli::proxy::sessions","filename":"src/cli/proxy/sessions.rs"}
{"timestamp":"2024-03-20T18:49:02.030086Z","level":"ERROR","fields":{"message":"downstream channel full"},"target":"quilkin::cli::proxy::sessions","filename":"src/cli/proxy/sessions.rs"}
{"timestamp":"2024-03-20T18:49:02.030284Z","level":"ERROR","fields":{"message":"downstream channel full"},"target":"quilkin::cli::proxy::sessions","filename":"src/cli/proxy/sessions.rs"}
{"timestamp":"2024-03-20T18:49:02.030314Z","level":"ERROR","fields":{"message":"downstream channel full"},"target":"quilkin::cli::proxy::sessions","filename":"src/cli/proxy/sessions.rs"}
{"timestamp":"2024-03-20T18:49:02.030343Z","level":"ERROR","fields":{"message":"downstream channel full"},"target":"quilkin::cli::proxy::sessions","filename":"src/cli/proxy/sessions.rs"}
@ajohnstonTC ajohnstonTC added the kind/bug Something isn't working label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant