Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag --incompatible_disable_starlark_host_transitions will break Cloud Robotics Core in Bazel 7.0 #95

Closed
keertk opened this issue Dec 15, 2022 · 4 comments · Fixed by #175
Closed

Flag --incompatible_disable_starlark_host_transitions will break Cloud Robotics Core in Bazel 7.0 #95

keertk opened this issue Dec 15, 2022 · 4 comments · Fixed by #175
Labels
build build system related

Comments

@keertk
Copy link

keertk commented Dec 15, 2022

Incompatible flag --incompatible_disable_starlark_host_transitions will be enabled by default in the next major release (Bazel 7.0), thus breaking Cloud Robotics Core. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: bazelbuild/bazel#17032.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.
@keertk keertk mentioned this issue Dec 15, 2022
Open
@ensonic ensonic added the build build system related label Feb 28, 2023
@sgowroji
Copy link

Hi @ensonic, Could you please look into this issue and share any significant update. Thanks!

@ensonic
Copy link
Contributor

ensonic commented Jun 19, 2023 •
edited
Loading

We're trying to port from rules_docker to rules_oci (see #130), but have trouble finding a good replacement for:

load("@io_bazel_rules_docker//container:providers.bzl", "ImageInfo", "ImportInfo")

see https://github.com/googlecloudrobotics/core/blob/main/bazel/app_chart.bzl#L1

WIP PR: #163

Any ideas?

@drigz
Copy link
Contributor

drigz commented Jun 23, 2023

I had a look at rules_oci and found that it reads the digest from a file index.json: https://github.com/bazel-contrib/rules_oci/blob/d79412e7aadbb835f8e15819c6f67323d430430d/oci/private/push.sh.tpl#L40

Is that file generated for the images in #163? Can we adapt our rules to read the digest from index.json?

@ensonic
Copy link
Contributor

ensonic commented Jul 14, 2023

The only pending migration:

Migration is needed for the following flags:
--
  | --incompatible_disable_starlark_host_transitions

@ensonic ensonic closed this as completed Jul 14, 2023
drigz added a commit that referenced this issue Jul 14, 2023
@drigz
Bump rules_go, rules_pkg, gazelle, and buildtools
f0ef081 
Tested with `bazel build --incompatible_disable_starlark_host_transitions
//...`. Fixes #95.

These aren't the newest rules_go/gazelle because of
bazel-contrib/rules_go#3625.
@drigz drigz mentioned this issue Jul 14, 2023
Merged
drigz added a commit that referenced this issue Jul 14, 2023
@drigz
Bump rules_go, rules_pkg, gazelle, and buildtools (#175)
15e6d3f 
Tested with `bazel build
--incompatible_disable_starlark_host_transitions //...`. Fixes #95.

These aren't the newest rules_go/gazelle because of
bazel-contrib/rules_go#3625.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build build system related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump rules_go, rules_pkg, gazelle, and buildtools googlecloudrobotics/core
4 participants
@drigz @ensonic @sgowroji @keertk