You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
However this way of detecting node is completely wrong.
First issue, the practical one. If you use the <script> version of babel-polyfill this code will declare that the browser isNode and stacky will attempt to require things.
Second problem, the idealistic one. Adding global to browsers was a proposal that made it to stage-3, i.e. nearly included into the standard and implementation attempted by browsers.
This kind of irresponsible code that equates global to Node.js/CommonJS/require is the reason we're having an issue with getting that to stage-4.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
stacky uses this code to detect Node.js.
However this way of detecting node is completely wrong.
First issue, the practical one. If you use the
<script>
version ofbabel-polyfill
this code will declare that the browser isNode and stacky will attempt torequire
things.Second problem, the idealistic one. Adding
global
to browsers was a proposal that made it to stage-3, i.e. nearly included into the standard and implementation attempted by browsers.This kind of irresponsible code that equates
global
to Node.js/CommonJS/require is the reason we're having an issue with getting that to stage-4.The text was updated successfully, but these errors were encountered: