Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [node] add auto-approve templates, and install dependencies with engines-strict #328

Merged
merged 4 commits into from
Jun 6, 2024
Merged

chore: [node] add auto-approve templates, and install dependencies with engines-strict #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
163f0a4
chore: [node] add auto-approve templates, and install dependencies wi…
gcf-owl-bot[bot] May 31, 2024
9e9b2da
Update package.json
sofisl Jun 6, 2024
6feab7e
Update package.json
sofisl Jun 6, 2024
07c0fa6
run lint
sofisl Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/.OwlBot.lock.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2023 Google LLC
# Copyright 2024 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -13,5 +13,5 @@
# limitations under the License.
docker:
image: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest
digest: sha256:bfe4592953269bfa8d135200ca1b17809f106a337a885d7ecc12cd2a9998e98a
# created: 2023-11-15T20:00:24.246072277Z
digest: sha256:68e1cece0d6d3336c4f1cb9d2857b020af5574dff6da6349293d1c6d4eea82d8
# created: 2024-05-31T15:46:42.989947733Z
3 changes: 2 additions & 1 deletion .github/auto-approve.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
processes:
- "NodeDependency"
- "OwlBotTemplateChanges"
- "OwlBotTemplateChangesNode"
- "OwlBotPRsNode"
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- run: npm install --production --engine-strict --ignore-scripts --no-package-lock
# Clean up the production install, before installing dev/production:
- run: rm -rf node_modules
- run: npm install
- run: npm install --engine-strict
- run: npm test
env:
MOCHA_THROW_DEPRECATION: false
Expand All @@ -33,7 +33,7 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 14
- run: npm install
- run: npm install --engine-strict
- run: npm test
env:
MOCHA_THROW_DEPRECATION: false
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,15 @@
},
"devDependencies": {
"@babel/plugin-proposal-private-methods": "^7.18.6",
"@compodoc/compodoc": "^1.1.9",
"@compodoc/compodoc": "1.1.19",
"@types/mocha": "^10.0.0",
"@types/node-fetch": "^2.5.7",
"@types/sinon": "^17.0.0",
"@types/uuid": "^9.0.0",
"c8": "^9.0.0",
"codecov": "^3.1.0",
"gts": "^5.0.0",
"linkinator": "^4.0.0",
"linkinator": "^3.0.0",
"mocha": "^10.0.0",
"nock": "^13.0.0",
"sinon": "^17.0.0",
Expand Down
5 changes: 2 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,8 @@ function teenyRequest(
throw new Error('Multipart without callback is not implemented.');
}
const boundary: string = uuid.v4();
(options.headers as Headers)[
'Content-Type'
] = `multipart/related; boundary=${boundary}`;
(options.headers as Headers)['Content-Type'] =
`multipart/related; boundary=${boundary}`;
options.body = createMultipartStream(boundary, multipart);

// Multipart upload
Expand Down
Loading