refactor: fix test_assign_new_column_w_literal on pa.Scalar None value

chelsea-lin · chelsea-lin · commit 0196cb178d63 · 2026-01-16T06:38:36.000Z
diff --git a/bigframes/core/compile/sqlglot/sqlglot_ir.py b/bigframes/core/compile/sqlglot/sqlglot_ir.py
@@ -674,7 +674,7 @@ def _literal(value: typing.Any, dtype: dtypes.Dtype) -> sge.Expression:
             expressions=[_literal(value=v, dtype=value_type) for v in value]
         )
         return values if len(value) > 0 else _cast(values, sqlglot_type)
-    elif pd.isna(value):
+    elif pd.isna(value) or (isinstance(value, pa.Scalar) and not value.is_valid):
         return _cast(sge.Null(), sqlglot_type)
     elif dtype == dtypes.JSON_DTYPE:
         return sge.ParseJSON(this=sge.convert(str(value)))

Original file line number	Diff line number	Diff line change
`@@ -674,7 +674,7 @@ def _literal(value: typing.Any, dtype: dtypes.Dtype) -> sge.Expression:`
`674`	`674`	`expressions=[_literal(value=v, dtype=value_type) for v in value]`
`675`	`675`	`)`
`676`	`676`	`return values if len(value) > 0 else _cast(values, sqlglot_type)`
`677`		`- elif pd.isna(value):`
	`677`	`+ elif pd.isna(value) or (isinstance(value, pa.Scalar) and not value.is_valid):`
`678`	`678`	`return _cast(sge.Null(), sqlglot_type)`
`679`	`679`	`elif dtype == dtypes.JSON_DTYPE:`
`680`	`680`	`return sge.ParseJSON(this=sge.convert(str(value)))`