Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable logging from http requests and responses. #975

Closed
wants to merge 1 commit into from

Conversation

clundin25
Copy link
Contributor

The contents of the Auth library requests contains sensitive data
that should not be logged.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes googleapis/google-http-java-client#1705 ☕️

If you write sample code, please follow the samples format.

The contents of the Auth library requests contains sensitive data
that should not be logged.
@clundin25 clundin25 requested a review from a team as a code owner August 11, 2022 00:47
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 11, 2022
Copy link
Member

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's cancel this one

@clundin25 clundin25 closed this Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google-http-java-client being used by storage library logs partial access tokens.
2 participants