Skip to content

docs(bigframes): add a notebook explaining bqsql magics cell chaining#17216

Merged
tswast merged 6 commits into
mainfrom
tswast-magics-blog
Jun 9, 2026
Merged

docs(bigframes): add a notebook explaining bqsql magics cell chaining#17216
tswast merged 6 commits into
mainfrom
tswast-magics-blog

Conversation

@tswast

@tswast tswast commented May 20, 2026

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Jupyter notebook tutorial demonstrating how to query local Excel files using BigQuery DataFrames. The reviewer identified several critical issues: the notebook contains significant redundancy and redundant implementation drafts that should be refactored into a single linear tutorial. Furthermore, there is a functional error where the %%bqsql magic fails because the extension is not loaded in a code cell, and a hardcoded project ID needs to be replaced with a placeholder for user accessibility.

Comment thread packages/bigframes/notebooks/dataframes/magics_with_local_data.ipynb Outdated
Comment thread packages/bigframes/notebooks/dataframes/magics_with_local_data.ipynb Outdated
@tswast tswast changed the title Tswast magics blog docs(bigframes): add a notebook explaining bqsql magics cell chaining May 29, 2026
@tswast tswast marked this pull request as ready for review May 29, 2026 17:24
@tswast tswast requested review from a team as code owners May 29, 2026 17:24
@tswast tswast requested review from sycai and removed request for a team May 29, 2026 17:24
split notebook cells

rewrite to focus on chaining
@tswast tswast force-pushed the tswast-magics-blog branch from 9d7351b to d078deb Compare June 8, 2026 16:10
Comment on lines +1182 to +1184
"import bigframes.pandas as bpd\n",
"\n",
"bpd.options.bigquery.project = \"bigframes-dev\" # Your project ID here.\n"

@sycai sycai Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably write code like this:

PROJECT_ID = "" # @param {type:"string"}
bpd.options.bigquery.project = PROJECT_ID

for test ID injeciton. Ref: #17000

Comment thread packages/bigframes/docs/user_guide/index.rst Outdated
@tswast tswast enabled auto-merge (squash) June 9, 2026 14:04
@tswast tswast merged commit 1a0de4a into main Jun 9, 2026
32 checks passed
@tswast tswast deleted the tswast-magics-blog branch June 9, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants