docs(bigframes): add a notebook explaining bqsql magics cell chaining#17216
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new Jupyter notebook tutorial demonstrating how to query local Excel files using BigQuery DataFrames. The reviewer identified several critical issues: the notebook contains significant redundancy and redundant implementation drafts that should be refactored into a single linear tutorial. Furthermore, there is a functional error where the %%bqsql magic fails because the extension is not loaded in a code cell, and a hardcoded project ID needs to be replaced with a placeholder for user accessibility.
split notebook cells rewrite to focus on chaining
9d7351b to
d078deb
Compare
sycai
reviewed
Jun 8, 2026
Comment on lines
+1182
to
+1184
| "import bigframes.pandas as bpd\n", | ||
| "\n", | ||
| "bpd.options.bigquery.project = \"bigframes-dev\" # Your project ID here.\n" |
Contributor
There was a problem hiding this comment.
We should probably write code like this:
PROJECT_ID = "" # @param {type:"string"}
bpd.options.bigquery.project = PROJECT_ID
for test ID injeciton. Ref: #17000
sycai
approved these changes
Jun 8, 2026
tswast
commented
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕