Skip to content

auth: configure_mtls_channel() discards existing session configuration #18314

Description

@nbayati

In AsyncAuthorizedSession.configure_mtls_channel() (packages/google-auth/google/auth/aio/transport/sessions.py), configuring mutual TLS replaces self._auth_request with a newly constructed aiohttp.ClientSession and aiohttp.TCPConnector:

connector = aiohttp.TCPConnector(ssl=ssl_context)
new_session = aiohttp.ClientSession(connector=connector)
old_auth_request = self._auth_request
self._auth_request = AiohttpRequest(session=new_session)

Because new_session is instantiated from scratch with default arguments, we lose any custom configurations provided by callers on the initial session, such as connection pool limits, timeouts, etc.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions