Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing code_verifier argument from Flow.from_client_config() to class constructor is missing. #45

Open
tamaroth opened this issue Jun 12, 2019 · 0 comments
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tamaroth
Copy link

tamaroth commented Jun 12, 2019

With the introduction of code_verifier it should be possible to pass our own code_verifier to Flow.from_client_config() classmethod.

Currently, if you pass it as kwargs, the requests_oauth session creation will fail because code_verifier is not supposed to be in kwargs for that class and if it didn't, the value itself would not be passed to the constructor.

I think it would be a good idea to include code_verifier as a positional argument for the from_client_config() function.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 13, 2019
@sduskis sduskis added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Jun 16, 2019
@busunkim96 busunkim96 self-assigned this Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants