Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an rpc whose request message has a repeated field in the method signature #373

Open
software-dov opened this issue May 11, 2020 · 1 comment
Open

Add an rpc whose request message has a repeated field in the method signature #373

software-dov opened this issue May 11, 2020 · 1 comment
Labels
good first issue This issue is a good place to started contributing to this repository. priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@software-dov
Copy link
Contributor

There are currently no methods whose input message type contains a repeated field (with the exception of testing.proto:VerifyTestRequest, which as a repeated bytes field), and, therefore, no methods with a repeated field in their signatures.
This constitutes a test hole, as there are real APIs with these characteristics, and generators need to support this functionality and have tests that verify its integrity.

See also googleapis/gapic-generator-python#413 and googleapis/gapic-generator-python#410 for additional background.
@software-dov software-dov added enhancement good first issue This issue is a good place to started contributing to this repository. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 11, 2020
@JustinBeckwith JustinBeckwith added the type: process A process-related concern. May include testing, release, or the like. label Jan 28, 2021
@scouvreur
Copy link

Hey @software-dov - is anyone working on this ? If not could I have a look into it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This issue is a good place to started contributing to this repository. priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JustinBeckwith @software-dov @scouvreur