Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update unit tests for paginated methods and determine what bad paginated methods are #2199

Open
ohmayr opened this issue Sep 25, 2024 · 0 comments
Open

update unit tests for paginated methods and determine what bad paginated methods are #2199

ohmayr opened this issue Sep 25, 2024 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@ohmayr
Copy link
Contributor

ohmayr commented Sep 25, 2024

We have the following assert statement in our unit tests for paginated methods:

assert response.raw_page is response

This statement is added particularly to add code coverage for bad paginated methods. Investigate, what these bad paginated methods are, and determine if there's a better way to test / add coverage for these methods.
@ohmayr ohmayr mentioned this issue Sep 25, 2024
Merged
@vchudnov-g vchudnov-g added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@parthea @vchudnov-g @ohmayr