Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update type hints for credentials in the async client layer #2177

Open
ohmayr opened this issue Sep 20, 2024 · 0 comments
Open

Update type hints for credentials in the async client layer #2177

ohmayr opened this issue Sep 20, 2024 · 0 comments
Assignees
@ohmayr
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@ohmayr
Copy link
Contributor

ohmayr commented Sep 20, 2024

Update the credentials type hint in the async client constructor to include asynchronous credentials i.e. async credentials should also support google.auth.aio.credentials.Credentials which are required by the async rest transport.

For now, the type hint isn't updated in the client layer and mypy warnings are silenced by adding # type: ignore in the async rest transport constructor. This can be looked up by searching for this issue.

Related issue: #2173
@vchudnov-g vchudnov-g added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 20, 2024
@vchudnov-g vchudnov-g assigned ohmayr and unassigned parthea Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ohmayr ohmayr

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@parthea @vchudnov-g @ohmayr