Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy package uses PHP 8 syntax #1058

Open
gvidasdgn opened this issue Dec 11, 2024 · 1 comment
Open

Legacy package uses PHP 8 syntax #1058

gvidasdgn opened this issue Dec 11, 2024 · 1 comment
Labels
bug Something isn't working triage Need triage

Comments

@gvidasdgn
Copy link

The legacy package (dev-legacy-v25.0.0) has 2 lines of code with PHP 8 syntax, using the null safe operator (?->)

google-ads-php/src/Google/Ads/GoogleAds/Lib/V18/InfoRedactor.php

Line 388 in 65a3d8f

if ($localServicesLead?->getContactDetails()?->getEmail()) {

google-ads-php/src/Google/Ads/GoogleAds/Lib/V18/InfoRedactor.php

Line 402 in 65a3d8f

if ($localServicesLeadConversation?->getMessageDetails()?->getText()) {

@gvidasdgn gvidasdgn added bug Something isn't working triage Need triage labels Dec 11, 2024
@fiboknacky
Copy link
Member

Thanks for reporting. Will work on it soon.

@fiboknacky fiboknacky mentioned this issue Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage Need triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fiboknacky @gvidasdgn