Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature that fixes unanalyzable-dynamic-import to work correctly with jsr.io #1004

Open
DanielPickens opened this issue Dec 18, 2024 · 0 comments

Comments

@DanielPickens
Copy link

DanielPickens commented Dec 18, 2024

Description
Add a new feature method to node:URL async functionMain that fixes unanalyzable-dynamic-import to work correctly with jsr.io and adds extended functionality for ImportGlobalRequire to parse deps of import paths on origin when call reference is calling from object reference value calls that are not multi inheritated to await url method for property object:pathToFileURL to call filepath from .toString() method call and allow for analyzable-dynamic-imports to work correctly with jsr.io filepath imports.

Why is this needed:
This would fix the issue of unanalyzable-dynamic-import to work correctly with jsr.io not getting called dynamically to recognize dynamic import paths so that dynamic imports can have methods that allow for analyzable-dynamic-imports path object value fields that the jsr.io filepath imports can load configs onto the await functionMain asynchronously like:

const dynamicImport = new Function('modulePath', 'return import(modulePath)');
  await dynamicImport(url.pathToFileURL(filepath).toString());
}

What would you like to be added:
This would add decoupling to a non-dynamic-import function so that the assorted function would work correctly with jsr.io import filepaths when called from a url() property object referenced value object context

Method referenced:

 await import(url.pathToFileURL(filepath).toString())
}

Who is this feature for?
@google/src/cli.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant