Skip to content

gather_design_stats should not overwrite design stats when provided when multiple logs #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
proppy opened this issue Apr 24, 2025 · 0 comments
Labels
bug Something isn't working or is incorrect ux User experience (end-user invoking XLS and its related tools)

Comments

@proppy
Copy link
Member

proppy commented Apr 24, 2025

Describe the bug
Not sure if this is the intended behavior, but it seems that gather_design_stats always overwrite the same design stats entry when provided with multiple log files.

To Reproduce
Run gather_design_stats with multiple files, notice that only the last of the provided log files is represented in the resulting proto.

Expected behavior
Either of the following behavior would be desirable instead:

  • an error when providing more than one log files
  • an average of all the metrics from the provided designs (assuming they all refer to the same design)
  • a flag to support more than one design stats (and write the resulting data to a repeated proto or a https://github.com/google/riegeli file.
@proppy proppy added bug Something isn't working or is incorrect ux User experience (end-user invoking XLS and its related tools) labels Apr 24, 2025
@proppy proppy changed the title gather_design_stats should not overwrite design stats when provided when multiple files gather_design_stats should not overwrite design stats when provided when multiple logs Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or is incorrect ux User experience (end-user invoking XLS and its related tools)
Projects
None yet
Development

No branches or pull requests

1 participant