Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/build: detect build kills as infrastructure errors #5510

Open
dvyukov opened this issue Nov 14, 2024 · 2 comments
Open

pkg/build: detect build kills as infrastructure errors #5510

dvyukov opened this issue Nov 14, 2024 · 2 comments
Labels

Comments

@dvyukov
Copy link
Collaborator

dvyukov commented Nov 14, 2024

Another incarnation of #5317 : syzkaller build failed as:

touch .descriptions
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=a8c9939451aee6b1bb2809bdd4edf640b2da431f -X 'github.com/google/syzkaller/prog.gitRevisionDate=20241113-150009'" -o ./bin/syz-manager github.com/google/syzkaller/syz-manager
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=a8c9939451aee6b1bb2809bdd4edf640b2da431f -X 'github.com/google/syzkaller/prog.gitRevisionDate=20241113-150009'" -o ./bin/syz-repro github.com/google/syzkaller/tools/syz-repro
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=a8c9939451aee6b1bb2809bdd4edf640b2da431f -X 'github.com/google/syzkaller/prog.gitRevisionDate=20241113-150009'" -o ./bin/syz-mutate github.com/google/syzkaller/tools/syz-mutate
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=a8c9939451aee6b1bb2809bdd4edf640b2da431f -X 'github.com/google/syzkaller/prog.gitRevisionDate=20241113-150009'" -o ./bin/syz-prog2c github.com/google/syzkaller/tools/syz-prog2c
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=a8c9939451aee6b1bb2809bdd4edf640b2da431f -X 'github.com/google/syzkaller/prog.gitRevisionDate=20241113-150009'" -o ./bin/syz-db github.com/google/syzkaller/tools/syz-db
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=a8c9939451aee6b1bb2809bdd4edf640b2da431f -X 'github.com/google/syzkaller/prog.gitRevisionDate=20241113-150009'" -o ./bin/syz-upgrade github.com/google/syzkaller/tools/syz-upgrade
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=a8c9939451aee6b1bb2809bdd4edf640b2da431f -X 'github.com/google/syzkaller/prog.gitRevisionDate=20241113-150009'" -o ./bin/syz-ci github.com/google/syzkaller/syz-ci
go: error obtaining buildID for go tool compile: fork/exec /syzkaller/gopath/pkg/mod/golang.org/[email protected]/pkg/tool/linux_amd64/compile: resource temporarily unavailable
go: error obtaining buildID for go tool asm: fork/exec /syzkaller/gopath/pkg/mod/golang.org/[email protected]/pkg/tool/linux_amd64/asm: resource temporarily unavailable
make: *** [Makefile:156: manager] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Makefile:168: repro] Error 1
@dvyukov dvyukov added the bug label Nov 14, 2024
@a-nogikh
Copy link
Collaborator

a-nogikh commented Nov 14, 2024

It looks more of a pkg/instance problem that pkg/build.

func (env *env) BuildSyzkaller(repoURL, commit string) (string, error) {


Where did it happen and what should have syzkaller done differently?

Should we, similarly to kernel build errors, report dashapi.BisectResultInfraError if it happened during bisection and not report it as a crash if it happened when syz-ci tried to update itself?

syzkaller/syz-ci/updater.go

Lines 217 to 220 in a8c9939

if err := upd.build(commit); err != nil {
log.Logf(0, "syzkaller: %v", err)
upd.uploadBuildError(commit, err)
}

@dvyukov
Copy link
Collaborator Author

dvyukov commented Nov 14, 2024

Where did it happen and what should have syzkaller done differently?

See internal bug 378963998. An alert instead of a filed bug + red dashboard may be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants