Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

MessageDifferencer ignoreFields doesn't work for RepeatedFields. #580

Open
sumitbh250 opened this issue Oct 23, 2019 · 4 comments
Open

MessageDifferencer ignoreFields doesn't work for RepeatedFields. #580

sumitbh250 opened this issue Oct 23, 2019 · 4 comments

Comments

@sumitbh250
Copy link

sumitbh250 commented Oct 23, 2019

    message B {
        message C {
            optional string details = 1;
            optional string time = 2;
        }
        repeated C c = 1;
    }
    repeated B b = 1;
}```

If message is of the above form and if we add details to ignoreField MessageDifferencer.compare doesn't work if number of RepeatedFields is different.
@oferb
Copy link
Contributor

oferb commented Oct 23, 2019

We just forked the code in truth. Can you put this issue on the truth repo?
https://github.com/google/truth

@sumitbh250
Copy link
Author

@oferb Can you point me to this file in truth repo? It seems it's not present there.

@oferb
Copy link
Contributor

oferb commented Oct 23, 2019

Indeed, looks like it was deleted:
google/truth@b009421

@oferb
Copy link
Contributor

oferb commented Oct 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants