Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

tools/reviewer/webapp should build and run with Bazel instead of npm #353

Open
Jdban opened this issue Oct 12, 2018 · 1 comment
Open

tools/reviewer/webapp should build and run with Bazel instead of npm #353

Jdban opened this issue Oct 12, 2018 · 1 comment
Labels

Comments

@Jdban
Copy link
Contributor

Jdban commented Oct 12, 2018

It's in the monorepo which uses Bazel for the build, so the frontend should be built with Bazel too!
The build process right now is a manual npm run build after the bazel build which doesn't scale well once more projects are introduced and all these npm run build steps have to be run separately. It should take advantage of the speed of Bazel!

Here is an example Angular project building with Bazel: https://github.com/alexeagle/angular-bazel-example

@oferb
Copy link
Contributor

oferb commented Oct 13, 2018

Yup :)
I'm waiting for that to mature a bit more, but definitely on our radar!

@oferb oferb added the P3 label Oct 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants