Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

(OKR 2017 Q3) For 5 types of errors, display the line/file of root cause #20

Open
protobird-git opened this issue Aug 14, 2017 · 0 comments
Assignees

Comments

@protobird-git
Copy link
Contributor

See OKR

mbjorge added a commit that referenced this issue Sep 24, 2017
Support clear error messaging for:
  - Missing semicolons
  - Missing quote on string literal
  - Did-You-Mean suggestions for all NameErrors
  - Missing pre_states and post_states
  - Empty pre_states

Issue #2
Issue #20

Test: parser_error_test.py, sprockets_end_to_end_test.py
mbjorge added a commit that referenced this issue Oct 12, 2017
* Add better error messaging for common syntax errors.

Support clear error messaging for:
  - Missing semicolons
  - Missing quote on string literal
  - Did-You-Mean suggestions for all NameErrors
  - Missing pre_states and post_states
  - Empty pre_states

Issue #2
Issue #20

Test: parser_error_test.py, sprockets_end_to_end_test.py

* Make classes for lexer errors and parser errors

* Split parser_error, lexer_error, and test_data into files.

To keep things neat and tidy, split out more things into files.

* More clean up

- Pull out the list of errors into a global
- Put lexer errors first, since they have lower numbers
- Update docstrings to reflect new numbering
- Don't create temp files in end_to_end test
- Update parser_error_test to use the new error objects
- Update travis.yml to run the end-to-end test

* Mock out the test_driver.Visualizer

Could not get `dot` to install from graphviz correctly,
so just mock out the Visualizer, since it's not needed for the
end_to_end test behaviour.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants