Skip to content

Commit 4e693db

Browse files
committed
Use C++11 style instead of C++20
1 parent a60fd60 commit 4e693db

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

snappy_benchmark.cc

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ namespace {
4646

4747
void FilesAndLevels(::testing::Benchmark* benchmark) {
4848
for (int i = 0; i < ARRAYSIZE(kTestDataFiles); ++i) {
49-
for (int level = snappy::CompressionOptions::MinCompressionLevel();
49+
for (int/*level=*/snappy::CompressionOptions::MinCompressionLevel();
5050
level <= snappy::CompressionOptions::MaxCompressionLevel(); ++level) {
5151
benchmark->ArgPair(i, level);
5252
}
@@ -65,7 +65,7 @@ void BM_UFlat(benchmark::State& state) {
6565

6666
std::string zcontents;
6767
snappy::Compress(contents.data(), contents.size(), &zcontents,
68-
snappy::CompressionOptions{.level = state.range(1)});
68+
snappy::CompressionOptions{/*level=*/state.range(1)});
6969
char* dst = new char[contents.size()];
7070

7171
for (auto s : state) {
@@ -130,7 +130,7 @@ void BM_UValidate(benchmark::State& state) {
130130

131131
std::string zcontents;
132132
snappy::Compress(contents.data(), contents.size(), &zcontents,
133-
snappy::CompressionOptions{.level = state.range(1)});
133+
snappy::CompressionOptions{/*level=*/state.range(1)});
134134

135135
for (auto s : state) {
136136
CHECK(snappy::IsValidCompressedBuffer(zcontents.data(), zcontents.size()));
@@ -163,7 +163,7 @@ BENCHMARK(BM_UValidateMedley);
163163
void BM_UIOVecSource(benchmark::State& state) {
164164
// Pick file to process based on state.range(0).
165165
int file_index = state.range(0);
166-
int level = state.range(1);
166+
int/*level=*/state.range(1);
167167

168168
CHECK_GE(file_index, 0);
169169
CHECK_LT(file_index, ARRAYSIZE(kTestDataFiles));
@@ -193,7 +193,7 @@ void BM_UIOVecSource(benchmark::State& state) {
193193
size_t zsize = 0;
194194
for (auto s : state) {
195195
snappy::RawCompressFromIOVec(iov, contents.size(), dst, &zsize,
196-
snappy::CompressionOptions{.level = level});
196+
snappy::CompressionOptions{/*level=*/level});
197197
benchmark::DoNotOptimize(iov);
198198
}
199199
state.SetBytesProcessed(static_cast<int64_t>(state.iterations()) *
@@ -268,7 +268,7 @@ void BM_UFlatSink(benchmark::State& state) {
268268

269269
std::string zcontents;
270270
snappy::Compress(contents.data(), contents.size(), &zcontents,
271-
snappy::CompressionOptions{.level = state.range(1)});
271+
snappy::CompressionOptions{/*level=*/state.range(1)});
272272
char* dst = new char[contents.size()];
273273

274274
for (auto s : state) {
@@ -292,7 +292,7 @@ BENCHMARK(BM_UFlatSink)->Apply(FilesAndLevels);
292292
void BM_ZFlat(benchmark::State& state) {
293293
// Pick file to process based on state.range(0).
294294
int file_index = state.range(0);
295-
int level = state.range(1);
295+
int/*level=*/state.range(1);
296296

297297
CHECK_GE(file_index, 0);
298298
CHECK_LT(file_index, ARRAYSIZE(kTestDataFiles));
@@ -304,7 +304,7 @@ void BM_ZFlat(benchmark::State& state) {
304304
size_t zsize = 0;
305305
for (auto s : state) {
306306
snappy::RawCompress(contents.data(), contents.size(), dst, &zsize,
307-
snappy::CompressionOptions{.level = level});
307+
snappy::CompressionOptions{/*level=*/level});
308308
benchmark::DoNotOptimize(dst);
309309
}
310310
state.SetBytesProcessed(static_cast<int64_t>(state.iterations()) *
@@ -323,7 +323,7 @@ BENCHMARK(BM_ZFlat)->Apply(FilesAndLevels);
323323

324324
void BM_ZFlatAll(benchmark::State& state) {
325325
const int num_files = ARRAYSIZE(kTestDataFiles);
326-
int level = state.range(0);
326+
int/*level=*/state.range(0);
327327

328328
std::vector<std::string> contents(num_files);
329329
std::vector<char*> dst(num_files);
@@ -340,7 +340,7 @@ void BM_ZFlatAll(benchmark::State& state) {
340340
for (auto s : state) {
341341
for (int i = 0; i < num_files; ++i) {
342342
snappy::RawCompress(contents[i].data(), contents[i].size(), dst[i],
343-
&zsize, snappy::CompressionOptions{.level = level});
343+
&zsize, snappy::CompressionOptions{/*level=*/level});
344344
benchmark::DoNotOptimize(dst);
345345
}
346346
}
@@ -357,7 +357,7 @@ BENCHMARK(BM_ZFlatAll)->DenseRange(1, 2);
357357

358358
void BM_ZFlatIncreasingTableSize(benchmark::State& state) {
359359
CHECK_GT(ARRAYSIZE(kTestDataFiles), 0);
360-
int level = state.range(0);
360+
int/*level=*/state.range(0);
361361
const std::string base_content = ReadTestDataFile(
362362
kTestDataFiles[0].filename, kTestDataFiles[0].size_limit);
363363

@@ -377,7 +377,7 @@ void BM_ZFlatIncreasingTableSize(benchmark::State& state) {
377377
for (auto s : state) {
378378
for (size_t i = 0; i < contents.size(); ++i) {
379379
snappy::RawCompress(contents[i].data(), contents[i].size(), dst[i],
380-
&zsize, snappy::CompressionOptions{.level = level});
380+
&zsize, snappy::CompressionOptions{/*level=*/level});
381381
benchmark::DoNotOptimize(dst);
382382
}
383383
}

snappy_compress_fuzzer.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
4444
std::string compressed;
4545
size_t compressed_size =
4646
snappy::Compress(input.data(), input.size(), &compressed,
47-
snappy::CompressionOptions{.level = level});
47+
snappy::CompressionOptions{/*level=*/level});
4848

4949
(void)compressed_size; // Variable only used in debug builds.
5050
assert(compressed_size == compressed.size());

0 commit comments

Comments
 (0)