Skip to content

Commit 3c454ca

Browse files
Maggie DongSkCQ
authored andcommitted
Hide the Triage and Improvements buttons on the Regressions page when the table has not loaded.
Screenshot: https://screenshot.googleplex.com/5YshrT9jcx5yy3n Bug: b/385780389 Change-Id: Icd9cd8cbcb5b72446517b1b6b8d4a317fec237ad Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/932178 Reviewed-by: Wenbin Zhang <[email protected]> Commit-Queue: Maggie Dong <[email protected]>
1 parent c2fbf62 commit 3c454ca

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

perf/modules/anomalies-table-sk/anomalies-table-sk.ts

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -74,18 +74,20 @@ export class AnomaliesTableSk extends ElementSk {
7474
}
7575

7676
private static template = (ele: AnomaliesTableSk) => html`
77-
<button
78-
id="triage-button"
79-
@click="${ele.togglePopup}"
80-
?disabled="${ele.checkedAnomaliesSet.size === 0}">
81-
Triage
82-
</button>
83-
<button
84-
id="graph-button"
85-
@click="${ele.openReport}"
86-
?disabled="${ele.checkedAnomaliesSet.size === 0}">
87-
Graph
88-
</button>
77+
<div class="filter-buttons" ?hidden="${ele.anomalyList.length === 0}">
78+
<button
79+
id="triage-button"
80+
@click="${ele.togglePopup}"
81+
?disabled="${ele.checkedAnomaliesSet.size === 0}">
82+
Triage
83+
</button>
84+
<button
85+
id="graph-button"
86+
@click="${ele.openReport}"
87+
?disabled="${ele.checkedAnomaliesSet.size === 0}">
88+
Graph
89+
</button>
90+
</div>
8991
<div class="popup-container" ?hidden="${!ele.showPopup}">
9092
<div class="popup">
9193
<triage-menu-sk id="triage-menu"></triage-menu-sk>

0 commit comments

Comments
 (0)