Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the partial data state infrastructure to use pivot reports for audiences. #8602

Closed
1 task
techanvil opened this issue Apr 23, 2024 · 4 comments
Closed
1 task
Labels
Feature: Audiences Module: Analytics Google Analytics module related issues P2 Low priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature

Comments

@techanvil
Copy link
Collaborator

techanvil commented Apr 23, 2024

Feature Description

The initial implementation of the partial data state infrastructure requests a report per audience in order to determine the date of the first event for each audience.

Once we have added support for pivot reports (see #8484), we can reduce the number of reports by making a single request for a pivot report to retrieve the data for all audiences.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • When retrieving the partial data state for a set of audiences, a single pivot report should be requested to retrieve the data for all the audiences, rather than an individual report per audience.

Implementation Brief

For reference see the initial implementation of *determineResourceDataAvailabilityDate() and how it calls getPartialDataReportOptions() for each audience.

Test Coverage

QA Brief

Changelog entry

@techanvil techanvil added Module: Analytics Google Analytics module related issues P1 Medium priority Type: Enhancement Improvement of an existing feature labels Apr 23, 2024
@benbowler benbowler added the Team M Issues for Squad 2 label May 9, 2024
@benbowler benbowler self-assigned this May 29, 2024
@benbowler benbowler removed their assignment Jun 12, 2024
@techanvil techanvil added P2 Low priority and removed P1 Medium priority labels Jun 25, 2024
@benbowler benbowler assigned benbowler and unassigned benbowler Jun 27, 2024
@techanvil
Copy link
Collaborator Author

Moved to Backlog until we get all the P1 issues done and/or the initial release out.

@techanvil
Copy link
Collaborator Author

Note: This will need to be reviewed for viability in light of the issues with pivot reports for audiences as described in #8726 (comment).

@benbowler
Copy link
Collaborator

After realising pivot reporting was not appropriate for use in the Audience Segmentation work we don't have a clear use case for it in the current codebase and will remove it in #10298. As a result I'm closing this issue as it's no longer relevant.

@benbowler benbowler reopened this Mar 3, 2025
@benbowler
Copy link
Collaborator

Closing as not planned.

@benbowler benbowler closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Audiences Module: Analytics Google Analytics module related issues P2 Low priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants