Show Sign in with Google button when previewing page/post content, even when signed in

[tofumatt]

Bug Description

Currently, the Sign in with Google button Gutenberg block does not appear for users who are already signed in to their WordPress site.

But if you're previewing content, say from an edit page/post screen and then preview the draft content, the Sign in with Google button should appear, so you can preview how it would work in production.

Steps to reproduce

1. Enable the Sign in with Google module
2. Add a "Sign in with Google" block to a page/post
3. Preview the post
4. Notice the block does not appear in preview mode

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The Sign in with Google block should appear when previewing page/post content, but should not be loaded with a real client ID to prevent sign in from happening from preview mode.

Implementation Brief

• Update the following line to render the block if is_preview() even if the user is logged in, this will display the button on preview pages:

  • site-kit-wp/includes/Modules/Sign_In_With_Google/Sign_In_With_Google_Block.php

    Lines 85 to 87 in 00dee09

    	if ( is_user_logged_in() ) {
    	return '';
    	}

• Update the includes/Modules/Sign_In_With_Google.php:

  • Update the following line to render the button if is_preview():

    • site-kit-wp/includes/Modules/Sign_In_With_Google.php

      Line 503 in 00dee09

      <?php if ( ! is_user_logged_in() || $is_wp_login ) : // phpcs:ignore Generic.WhiteSpace.ScopeIndent.Incorrect ?>

  • Wrap the body of the handleCredentialResponse function in a PHP if statement that only outputs the function body if is_preview() is false to ensure the button does nothing on the preview page if clicked.

    • site-kit-wp/includes/Modules/Sign_In_With_Google.php

      Lines 468 to 487 in 00dee09

      	<?php if ( $is_woocommerce && ! $is_wp_login ) : // phpcs:ignore Generic.WhiteSpace.ScopeIndent.Incorrect ?>
      	response.integration = 'woocommerce';
      	<?php endif; // phpcs:ignore Generic.WhiteSpace.ScopeIndent.Incorrect ?>
      	try {
      	const res = await fetch( '<?php echo esc_js( $login_uri ); ?>', {
      	method: 'POST',
      	headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
      	body: new URLSearchParams( response )
      	} );
      	<?php if ( empty( $redirect_to ) && ! $is_login_page && $should_show_one_tap_prompt ) : // phpcs:ignore Generic.WhiteSpace.ScopeIndent.Incorrect ?>
      	location.reload();
      	<?php else : // phpcs:ignore Generic.WhiteSpace.ScopeIndent.Incorrect ?>
      	if ( res.ok && res.redirected ) {
      	location.assign( res.url );
      	}
      	<?php endif; // phpcs:ignore Generic.WhiteSpace.ScopeIndent.Incorrect ?>
      	} catch( error ) {
      	console.error( error );
      	}

  • Update the following line to not output one tap code if is_preview() is true.

    • site-kit-wp/includes/Modules/Sign_In_With_Google.php

      Line 517 in 00dee09

      <?php if ( $should_show_one_tap_prompt ) : // phpcs:ignore Generic.WhiteSpace.ScopeIndent.Incorrect ?>

Test Coverage

• Update the SiwG tests to confirm the button renders when is_preview() returns true and confirm there are no regressions where the button is rendered in other contexts.

QA Brief

Changelog entry

[eugene-manuilov]

@benbowler, this part from AC ...but should not be loaded with a real client ID to prevent sign in from happening from preview mode. is missing.

Update the can_render_signinwithgoogle method in includes/Modules/Sign_In_With_Google.php to return true if is_preview() is true.

I don't think we need to change the can_render_signinwithgoogle method at all because it will affect all places where we use this method. What we need to do is to update the render_signinwithgoogle method only to render the part of the script that renders the button. This also means that we should not activate the One-Tap feature in the preview mode even if it enabled. Plus, the callback function should not do anything in the preview mode.

[benbowler]

Sounds good @eugene-manuilov, updated to avoid changing can_render_signinwithgoogle and I added an addition line to skip writing the handleCredentialResponse body on the preview to make the button non-functional plus I skip the oneTap code when on the preview page.