Duplicate GET:google-tag-settings
requests on GA4 setup form load
#10283
Labels
Module: Analytics
Google Analytics module related issues
P1
Medium priority
Type: Bug
Something isn't working
Bug Description
When loading the setup for GA4, a duplicate request is observable for
GET:google-tag-settings
.Steps to reproduce
Screenshots
Additional Context
These calls are from the same effect in
SetupMain
and primarily due to not including a guard for accounts not being resolved yet.selectProperty
->site-kit-wp/assets/js/modules/analytics-4/datastore/properties.js
Lines 309 to 312 in 8f1c16b
updateSettingsForMeasurementID
->site-kit-wp/assets/js/modules/analytics-4/datastore/properties.js
Lines 545 to 547 in 8f1c16b
The simple check on
accounts
only is insufficient because accounts will be received and then sorted in separate actions which causes this to run twice.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: