Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate GET:google-tag-settings requests on GA4 setup form load #10283

Open
1 task
aaemnnosttv opened this issue Feb 27, 2025 · 0 comments
Open
1 task

Duplicate GET:google-tag-settings requests on GA4 setup form load #10283

aaemnnosttv opened this issue Feb 27, 2025 · 0 comments
Labels
Module: Analytics Google Analytics module related issues P1 Medium priority Type: Bug Something isn't working

Comments

@aaemnnosttv
Copy link
Collaborator

Bug Description

When loading the setup for GA4, a duplicate request is observable for GET:google-tag-settings.

Steps to reproduce

  1. Start GA4 set up
  2. Observe duplicate request

Screenshots

Image

Additional Context

These calls are from the same effect in SetupMain and primarily due to not including a guard for accounts not being resolved yet.

  1. selectProperty ->
    updateSettingsForMeasurementID(
    // eslint-disable-next-line sitekit/acronym-case
    webdatastream.webStreamData.measurementId
    );
  2. updateSettingsForMeasurementID ->
    yield fetchGetGoogleTagSettingsStore.actions.fetchGetGoogleTagSettings(
    measurementID
    );

The simple check on accounts only is insufficient because accounts will be received and then sorted in separate actions which causes this to run twice.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@aaemnnosttv aaemnnosttv added Module: Analytics Google Analytics module related issues P1 Medium priority Type: Bug Something isn't working labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Analytics Google Analytics module related issues P1 Medium priority Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant