Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Learn more" Link in Ads Module Setup CTA Banner #10278

Open
3 tasks done
10upsimon opened this issue Feb 27, 2025 · 3 comments
Open
3 tasks done

Update "Learn more" Link in Ads Module Setup CTA Banner #10278

10upsimon opened this issue Feb 27, 2025 · 3 comments
Labels
Module: Ads Google Ads module related issues P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@10upsimon
Copy link
Collaborator

10upsimon commented Feb 27, 2025

Feature Description

The href value of the "Learn more" link in the Ads Module Setup CTA Banner should be updated accordingly, to redirect the user to https://sitekit.withgoogle.com/documentation/using-site-kit/managing-ads/#setup.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The "Learn more" link within the Ads Setup CTA Banner directs the user to the correct location, which is https://sitekit.withgoogle.com/documentation/using-site-kit/managing-ads/#setup

Implementation Brief

  • Within the <AdsModuleSetupCTABanner> notification component at assets/js/modules/ads/components/notifications/AdsModuleSetupCTABanner.js
    • Update the value of the learnMoreURL const to store the result of the following CORE_SITE datastore selector:
      • select( CORE_SITE ).getDocumentationLinkURL('set-up-ads')

Test Coverage

  • N/A

QA Brief

Changelog entry

  • Update the "Learn more" link in the Ads Module Setup banner.
@10upsimon 10upsimon added Module: Ads Google Ads module related issues P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature labels Feb 27, 2025
@10upsimon 10upsimon self-assigned this Feb 27, 2025
@adamdunnage
Copy link
Collaborator

adamdunnage commented Feb 27, 2025

Added to the Site Kit redirects sheet:

Message: set up ads
Documentation URL: https://sitekit.withgoogle.com/documentation/using-site-kit/managing-ads/#setup

@10upsimon 10upsimon assigned zutigrm and unassigned 10upsimon Feb 28, 2025
@zutigrm
Copy link
Collaborator

zutigrm commented Feb 28, 2025

AC & IB ✅

@zutigrm zutigrm removed their assignment Feb 28, 2025
@10upsimon 10upsimon self-assigned this Feb 28, 2025
@10upsimon 10upsimon removed their assignment Feb 28, 2025
@zutigrm zutigrm assigned zutigrm and unassigned zutigrm Feb 28, 2025
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Feb 28, 2025
@mohitwp
Copy link
Collaborator

mohitwp commented Mar 3, 2025

QA Update ✅

Recording.1840.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Ads Google Ads module related issues P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

5 participants