Expose GLA conversion ID in the Ads datastore

[10upsimon]

Feature Description

As a dependency to #10257, there is a need to create a new REST controller to retrieve the value from the ads_conversion_action option, for use in the Ads module datastore. This is required in order to determine whether the warning notice should be surfaced for users manually entering the same Ads ID in Site Kit as was linked/configured/created in Google for WooCommerce.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• A new REST controller is created in Ads that retrieves the value of the ads_conversion_action option.
• Updates to the Ads module datastore are made and a selector added to retrieve said value above, if it exists.
• Ads datastore is updated to expose conversion ID from gla_ads_conversion_action option

Implementation Brief

Note: Since there was no need to protect the ID - it is already a public data, and fetching it was not time sensitive, approach was changed to store it in inline data

• Implement Google\Site_Kit\Modules\Ads::get_datapoint_definitions method
  • It should define GET:gla-connected-ads-id
  • Leave empty string for service
  • You can see an example of this, and method bellow in any other module class
• Implement Google\Site_Kit\Modules\Ads::create_data_request
  • Include GET:gla-connected-ads-id route callback, it should:
  • Retrieve gla_ads_conversion_action option value. It will be an array if option exists
    • Return early if option does not exists
  • Access value from conversion_id key of the retrieved array, and if set return it as response
• Add assets/js/modules/ads/datastore/google-listings-and-ads.js
  • Store the value in new initialState, say glaConnectedAdsId, with undefined as initial value
  • Add a fetch store fetchGetGLAConnectedAdsIdStore
    • it should retrieve the ads id from the newly added REST route (modules, ads, gla-connected-ads-id)
  • Add getGLAConnectedAdsId resolver to retrieve the data by invoking the fetch store
  • Add getGLAConnectedAdsId selector to return value from the state
  • Include the new datastore partial to the MODULES_ADS datastore

Test Coverage

• Add basic test coverage for the new datastore partial

QA Brief

• Setup Site Kit with adsPax feature flag enabled
• Go to Site Kit dashboard and paste this snippet in the console: await googlesitekit.data.select('modules/ads').getGoogleForWooCommerceConversionID()
• It should output empty string ''
• Activate and setup Google for WooCommerce plugin, after you complete the setup and connect it with Ads campaign go to dashboard and output the same snippet, it shoukld output the connected conversion ID, in will be in format of AW-xxxx

Changelog entry

• N/A

[zutigrm]

AC ✅

[10upsimon]

@zutigrm IB LGTM ✅ , thank you! Moving to EB.

[mohitwp]

QA Update ✅

• Tested on dev environment.
• Verified that when Google for WooCommerce plugin, was not Activated and setup on that time running code snippet await googlesitekit.data.select('modules/ads').getGoogleForWooCommerceConversionID() output empty string ''.
• Verified that after we complete the setup of Google For WooCommerce plugin and connect it with Ads campaign go to dashboard and output the same snippet, it output the connected conversion ID, in will be in format of AW-xxxx.

Not Connected and Setup

Connected and Setup

Recording.1836.mp4