Skip to content

Commit dfcce41

Browse files
authored
Merge pull request #7980 from google/fix-entity-dashboard-feature-tour-7979
2 parents ae624d2 + 1ad6f5f commit dfcce41

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

assets/js/components/FeatureTours.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,10 @@ export default function FeatureTours() {
5656
'js-googlesitekit-main-dashboard'
5757
);
5858

59+
if ( ! dashboardElement ) {
60+
return;
61+
}
62+
5963
const observer = new ResizeObserver( () => {
6064
global.dispatchEvent( new Event( 'resize' ) );
6165
} );

assets/js/components/FeatureTours.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ describe( 'FeatureTours', () => {
3434
let registry;
3535
let observeMock;
3636
let disconnectMock;
37-
const dashboardElementClassName = 'js-googlesitekit-main-dashboard';
37+
const dashboardElementID = 'js-googlesitekit-main-dashboard';
3838

3939
const TourTooltipsWithMockUI = () => (
4040
<div>
41-
<div className={ dashboardElementClassName }>
41+
<div id={ dashboardElementID }>
4242
<div className="test-tour-step-1-target" />
4343
</div>
4444
<FeatureTours />
@@ -104,7 +104,7 @@ describe( 'FeatureTours', () => {
104104
await waitForRegistry();
105105

106106
expect( observeMock ).toHaveBeenCalledWith(
107-
container.querySelector( dashboardElementClassName )
107+
container.querySelector( `#${ dashboardElementID }` )
108108
);
109109
} );
110110

0 commit comments

Comments
 (0)