Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] gmock appears to be necessary for shaderc #1406

Open
rubyFeedback opened this issue Mar 15, 2024 · 2 comments
Open

[Documentation] gmock appears to be necessary for shaderc #1406

rubyFeedback opened this issue Mar 15, 2024 · 2 comments

Comments

@rubyFeedback
Copy link

Could the main README briefly mention that gmock is a dependency; and where
to get it? Ideally in the main README, or some FAQ entry on the wiki or something
like that. That way people who want to get shaderc for the vulkan-releated stuff,
know where to go to next. Thanks for reading.

@ben-clayton
Copy link
Contributor

The step to fetch the dependency is listed in the root README:

https://github.com/google/shaderc?tab=readme-ov-file#getting-and-building-shaderc


  1. Check out the source code:
git clone https://github.com/google/shaderc $SOURCE_DIR
cd $SOURCE_DIR
./utils/git-sync-deps

You need to call ./utils/git-sync-deps.

@Zopolis4
Copy link

Zopolis4 commented Jul 9, 2024

I think the confusion here results from a missing googletest being reported as a missing gmock, even though gmock was absorbed into googletest some time ago.

third_party/CMakeLists.txt:

# Configure third party projects.
if(${SHADERC_ENABLE_TESTS})
  if (IS_DIRECTORY ${SHADERC_GOOGLE_TEST_DIR})
    add_subdirectory(${SHADERC_GOOGLE_TEST_DIR} googletest)
  endif()
  if (NOT TARGET gmock)
    message(FATAL_ERROR "gmock was not found - required for tests")
  endif()
endif()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants