Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print better messages for problems with tag filtering ranges #440

Open
nolanmar511 opened this issue Nov 21, 2018 · 5 comments
Open

Print better messages for problems with tag filtering ranges #440

nolanmar511 opened this issue Nov 21, 2018 · 5 comments
Labels
Priority: p2 Buganizer priority - P2 type: feat Buganizer type - Feature Request

Comments

@nolanmar511
Copy link
Contributor

Right now, 0B:256B is interpreted at a range for filtering tags, but 0:256B is not.

I think we should either infer that the units are the same for both parts of the range if units are only specified for one half of the range, or not require units for zero.
@nolanmar511
Copy link
Contributor Author

We should also, perhaps, provide a message to indicate when something that looks like a range is being interpreted as a regexp.

@aalexand
Copy link
Collaborator

I think complaining with a clear error message that units are different here would be sufficient to guide the user.

@nolanmar511
Copy link
Contributor Author

Make sense to me.

User originally started with "0:256" -- so perhaps we should also complain when there are no units.

@nolanmar511 nolanmar511 changed the title The tag filter "0:256B" should be interpreted as a range. User should be informed when things similar to tag ranges (like size=0:256, or x=0:52B) aren't interpreted as ranges. Nov 21, 2018
@nolanmar511 nolanmar511 changed the title User should be informed when things similar to tag ranges (like size=0:256, or x=0:52B) aren't interpreted as ranges. Print message when tag filtering range-like (0:256, or x=0:52B) aren't interpreted as ranges. Nov 21, 2018
@aalexand
Copy link
Collaborator

"0:256" is in count units I think.

@aalexand
Copy link
Collaborator

For "0:256" I'd expect an error message that tag X has the unit of Y but unit Z was used in the filter.

@nolanmar511 nolanmar511 changed the title Print message when tag filtering range-like (0:256, or x=0:52B) aren't interpreted as ranges. Print better messages for problems with tag filtering ranges Nov 21, 2018
@Louis-Ye Louis-Ye added type: feat Buganizer type - Feature Request Priority: p2 Buganizer priority - P2 labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: p2 Buganizer priority - P2 type: feat Buganizer type - Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aalexand @Louis-Ye @nolanmar511