Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a way to filter by process / command for perf.data-converted profiles #282

Open
nolanmar511 opened this issue Dec 15, 2017 · 4 comments
Labels
Priority: p2 Buganizer priority - P2 type: feat Buganizer type - Feature Request

Comments

@nolanmar511
Copy link
Contributor

The profile.proto data format does not have a specific way to note which process a sample came from. However, perf.data files tend to include samples from multiple processes.

When using pprof on perf.data files, it should be possible to determine which process a sample is from, and this should be displayed to the user.

@aalexand aalexand changed the title Make it possible to distinguish between samples in different processes which are part of the same profile. Have a way to filter by process / command for perf.data-converted profiles Jan 29, 2018
@aalexand
Copy link
Collaborator

The profile.proto data format does not have a specific way to note which process a sample came from.

The easiest would be using tags. The perf_data_converter currently has a way to add process ID tags as part of conversion, I believe. We should make it so it also knows how to add command name tags, and then configure the converter run to add those tags. This will allow using tag filtering to filter by a specific process.

@aalexand
Copy link
Collaborator

@lannadorai Maybe you are the right owner for this after all. I think what we want here is make the perf data file conversion produce the process name / command label so that pprof can be used to filter by that tag.

@aalexand
Copy link
Collaborator

@lannadorai lannadorai removed their assignment Jul 7, 2020
@lannadorai
Copy link
Contributor

@aalexand Please assign this issue to the right person.

@aalexand aalexand added type: feat Buganizer type - Feature Request and removed enhancement labels May 12, 2023
@Louis-Ye Louis-Ye added the Priority: p2 Buganizer priority - P2 label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: p2 Buganizer priority - P2 type: feat Buganizer type - Feature Request
Projects
None yet
Development

No branches or pull requests

4 participants