Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Maven settings.xml are read correctly #409

Open
cuixq opened this issue Jan 23, 2025 · 2 comments
Open

Make sure Maven settings.xml are read correctly #409

cuixq opened this issue Jan 23, 2025 · 2 comments

Comments

@cuixq
Copy link
Collaborator

cuixq commented Jan 23, 2025

Maven authentication information is stored in local settings.xml.

Considering the extractor uses virtual filesystem, we need to refactor MavenRegistryAPIClient to use the virtual filesystem to read the local settings.

settings.xml is read when we construct NewMavenRegistryAPIClient and the client is constructed when the extractor is constructed which is before Extract() is called.

@oliverchang
Copy link
Collaborator

I discussed this with @michaelkedar earlier -- this is probably lower priority for now because auth only makes sense in the local developer use case where they have creds on their machine, and having a virtual filesystem isn't as necessary there.

@cuixq cuixq changed the title Use virtual filesystem to read local Maven settings Make sure Maven settings.xml are read correctly Feb 10, 2025
@erikvarga
Copy link
Collaborator

erikvarga commented Feb 11, 2025

What happens when we're scanning a remote container with SCALIBR? Would we expect the settings.xml be on the host that's running the scanner or on the container?
If it's on the remote container then this plugin wouldn't work for container scanning until we find a way to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants