fix(yarnlock): ignore yarn.lock files in node_modules
#417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
extractor/yarn-skip-node_modules
branch
from
99139e0 to
e146030
Compare
another-rex
approved these changes
Jan 30, 2025
|
No that's already doing this - overall I think we should have a general helper that's shared by all the JavaScript extractors as there's also some logic for handling max size, but I'll look into that as a follow up For now I've just done prs adding this specific logic to all js extractors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the behaviour of
packagelockjson, so I think it should be applied here too as I don't know of any tool which respects lockfiles innode_modules.This might fix #400