-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pillow] Removed python symlink #12326
Conversation
radarhere has previously contributed to projects/pillow. The previous PR was #11267 |
https://github.com/google/oss-fuzz/actions/runs/10331059544/job/28600812260?pr=12326#step:6:12
Hmm. I would have thought that is what is happening? |
@radarhere I think that check is failing because of the install at the bottom of the file: Also, thanks for investigating the failure in #12027! Out of curiosity, did the changes here work for you locally? Part of the changes I propose in that PR are aliasing the If it turns out that this does depends on the unmerged changes: I've been collecting patches that will be required after a Python 3.10 upgrade on a per broken project basis here: master...DaveLak:oss-fuzz:update-projects-after-python-10-upgrade and that includes Pillow's, dcd020c |
You're right, thanks - I've pushed a commit, and presubmit checks are satisfied now. |
I reckon the CI failed due to incompatible python version? ERROR: Package 'pillow' requires a different Python: 3.8.3 not in '>=3.9'
ERROR:__main__:Building fuzzers failed. |
Pillow dropped support for Python 3.8, so the error is already happening in master. This PR isn't intended to fix Pillow's oss-fuzz completely, merely to try and help the final solution of #12027. |
Yep, I will merge, then |
Pillow's oss-fuzz is currently failing, because Pillow main has dropped support for Python 3.8.
#12027 attempts to resolve this by upgrading the base builder to Python 3.10, but the latest status update over there says that Pillow fails in that branch with
So this pull request removes the python symlink in order to try and help.
cc @hugovk