Skip to content

Commit 08e507f

Browse files
authored
Add randomly generated decode tests (#712)
* Add randomly generated decode tests * change python tests to use assertAlmostEqual instead of hand rolled version * python formatting * remove rounding of coordinates in JS decode * undo rounding removal
1 parent 7d57797 commit 08e507f

2 files changed

Lines changed: 415 additions & 8 deletions

File tree

python/openlocationcode_test.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -142,14 +142,14 @@ def test_decoding(self):
142142
precision = 10
143143
for td in self.testdata:
144144
decoded = olc.decode(td['code'])
145-
self.assertEqual(round(decoded.latitudeLo, precision),
146-
round(td['latLo'], precision), td)
147-
self.assertEqual(round(decoded.longitudeLo, precision),
148-
round(td['lngLo'], precision), td)
149-
self.assertEqual(round(decoded.latitudeHi, precision),
150-
round(td['latHi'], precision), td)
151-
self.assertEqual(round(decoded.longitudeHi, precision),
152-
round(td['longHi'], precision), td)
145+
self.assertAlmostEqual(decoded.latitudeLo, td['latLo'], precision,
146+
td)
147+
self.assertAlmostEqual(decoded.longitudeLo, td['lngLo'], precision,
148+
td)
149+
self.assertAlmostEqual(decoded.latitudeHi, td['latHi'], precision,
150+
td)
151+
self.assertAlmostEqual(decoded.longitudeHi, td['longHi'], precision,
152+
td)
153153

154154

155155
class Benchmark(unittest.TestCase):

0 commit comments

Comments
 (0)